Skip to content

Fix resumable and non-resumable CE error ranges#18450

Merged
T-Gro merged 20 commits intodotnet:mainfrom
edgarfgp:fix-13789
Apr 14, 2025
Merged

Fix resumable and non-resumable CE error ranges#18450
T-Gro merged 20 commits intodotnet:mainfrom
edgarfgp:fix-13789

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Apr 5, 2025 •
edited
Loading

Description

BEFORE

Screenshot 2025-04-05 at 20 31 20

AFTER

open System.Threading.Tasks
let minimum () : Async<int> =
    async {
        let! batch = async { return 1 }
        return "1"
               ^^^
    }
    
let minimum () : Task<int> =
    task {
        let! batch = task { return 1 }
        return "1"
               ^^^
    }

Fixes #13789

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@edgarfgp edgarfgp mentioned this pull request Apr 7, 2025
Closed
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Apr 7, 2025

Updated the baselines locally and all test are passing. But the CI is not reflecting the same. Any tips @psfinaki ?

@psfinaki
Copy link
Contributor

psfinaki commented Apr 7, 2025

@edgarfgp yes :) I've checked out your branch.

The thing is that you're most likely running tests locally in the Debug mode (where they indeed pass) whereas the CI executes them in Release mode (where they fail locally as well). You're nearly there!

@edgarfgp edgarfgp marked this pull request as ready for review April 7, 2025 20:35
@edgarfgp edgarfgp requested a review from a team as a code owner April 7, 2025 20:35
@T-Gro T-Gro enabled auto-merge (squash) April 11, 2025 10:59
@edgarfgp edgarfgp requested a review from psfinaki April 14, 2025 10:52
psfinaki
psfinaki approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks Edgar :)

@T-Gro T-Gro merged commit 54321fe into dotnet:main Apr 14, 2025
33 checks passed
This was referenced May 15, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@brianrourkeboll brianrourkeboll brianrourkeboll left review comments

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing type inference error in task expression

4 participants

@edgarfgp @psfinaki @brianrourkeboll @T-Gro